Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling mobile hotspot with data saver on #4143

Open
Lppsoeht opened this issue Oct 16, 2024 · 4 comments · May be fixed by GrapheneOS/platform_packages_apps_Settings#308
Open

Allow enabling mobile hotspot with data saver on #4143

Lppsoeht opened this issue Oct 16, 2024 · 4 comments · May be fixed by GrapheneOS/platform_packages_apps_Settings#308
Labels
enhancement New feature or request

Comments

@Lppsoeht
Copy link

Lppsoeht commented Oct 16, 2024

Low priority, but there are certain circumstances where the user needs to enable the hotspot(some apps for example) but he still wants apps to treat the networking as data saver is still on.
Enabling the hotspot has nothing to do with using lots of cellular data.
It's an inconvenience having to disable and reenable data saver on and on.

@neelchauhan
Copy link

I have a PR for this: GrapheneOS/platform_packages_apps_Settings#308

Since I cannot test it in the emulator I'll need to get a spare Pixel to test.

@thestinger
Copy link
Member

This seems fine. It's strange that it disables it.

@neelchauhan
Copy link

The issue wasn't the emulator, but instead I removed a line of code which was critical. I reinstated the code.

Please review my GrapheneOS/platform_packages_apps_Settings#308 when you can.

@neelchauhan
Copy link

neelchauhan commented Dec 12, 2024

The good news is this PR works, but the bad news is that there are still UI bugs:

  • The statusbar gets stuck on "data saver on" even when this option is on

I'll add another PR for the statusbar.

Video: https://youtu.be/NlHA_toPIc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants