Settings: Add an option to allow tethering while Data Saver is on #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the standalone wallpaper picker class from WallpaperPicker2 as seen in the Pixel stock ROM.
The NFC preference in Settings -> Connected devices -> Connection preferences doesn't listen to changes from the NFC tile. (This wasn't an issue in Android 10, because there used to be a SwitchPreference that listened there.)
If no customization is needed, BoolSetting base class can be used directly from XML by adding settings:boolSettingField="<class name> <BoolSetting field name>" to the preference XML definition.
This preference controls the glove mode feature on Pixel devices for increased touch sensitivity without requiring a custom HAL or other device-side code. This is done by using the debug.touch_sensitivity_mode system property, which Settings has permission to change. The user-visible value is persisted in Settings.Secure, while the property is persisted in persist.vendor.touch_sensitivity_mode. Requires frameworks/base commit: "Add a config to state whether a device supports increased touch sensitivity." Requires device/google/* commit: "Express support for increased touch sensitivity." Closes: GrapheneOS#1 Co-authored-by: Diab Neiroukh <[email protected]> Change-Id: I86af721fde33226d314d8a44525f310828299a72
It's added to Private Space screen instead of the Apps screen (where regular and work profile links are) to avoid revealing whether the Private Space is present when the "Hide when locked" Private Space option is enabled.
Allow sorting applications by size in Settings->Apps just like in Settings->Storage/USB->Apps Change-Id: I9e022162110e1feff20f257992086e66735e0f5e
We would need some kind of automation to do this for all languages.
Signed-off-by: June <[email protected]> Co-authored-by: inthewaves <[email protected]> Co-authored-by: June <[email protected]>
Co-authored-by: inthewaves <[email protected]> Squashed with: Fix LTE Only mode on World Mode Co-authored-by: flawedworld <[email protected]>
The majority of apps that depend on Google Play services are currently incompatible with storage DCL restrictions due to Dynamite modules being loaded from the Play services data directory. Play services is in the process of converting Dynamite modules into APK splits, which will resolve this issue. Hide the setting until this Dynamite module conversion is complete.
AOSP launcher doesn't have this feature.
"Additional services" category shows available CredentialProvider services. It should use the Private Space userId, not the Owner userId. Original change: GrapheneOS#297
"None" app picker option was invisible because this activity wasn't updated to support edge-to-edge.
There was a mismatch between checks in getContactSharingState() and setContactSharingState(), which led to contacts access being granted by default when the user accepted a background pairing request for a hands-free device, despite the contacts access toggle indicating that the contacts access will not be granted. Fix this check mismatch by removing the confusing setContactSharingState() method and switching code that depends on setContactSharingState() to use the value of getContactSharingState() instead.
Before this change, contacts access toggle was turned on by default in foreground pairing dialogs for hands-free devices.
Fix back button not working properly on the owner credential input screen after activity configuration change. In that case, back button opened a second owner credential input screen instead of returning to the previous screen (the one that has the Duress password link).
There's a "Clear storage" button in App info > Storage & cache. When app implements a "manage storage space" activity, that button opens it instead of actually clearing the storage. "Manage space" activity might not provide an option to clear app storage or it might not work at all. This change adds a separate button to launch that activity and makes the "Clear storage" button ignore its presence.
neelchauhan
force-pushed
the
15-datasaver-tether
branch
5 times, most recently
from
6208866 to
46c54c0
Compare
|
The older version of this had bugs so I did a few force pushes and it should work now. Demo video: https://youtu.be/WGPIYk9h1N0 |
neelchauhan
force-pushed
the
15-datasaver-tether
branch
from
46c54c0 to
9412290
Compare
neelchauhan
force-pushed
the
15-datasaver-tether
branch
from
9412290 to
7d00acd
Compare
|
Data Saver is not enabled in the demo video. |
|
I think it's better to remove mDataSaverEnabled checks and simply show a confirmation prompt before entering the "Hotspot & tethering" screen when Data Saver is enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GrapheneOS/os-issue-tracker#4143