Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations #2187

Open
0HyperCube opened this issue Jan 11, 2025 · 0 comments
Open

Animations #2187

0HyperCube opened this issue Jan 11, 2025 · 0 comments
Labels
Architecture Involves architecture or engineering work or discussion Graphene Involves the node graph system/engine used by Graphite Performance Speed and efficiency improvements

Comments

@0HyperCube
Copy link
Member

Since there was no issue open
Previously discussed in #1601.
A partial implementation in #1766.
Set as a Google Summer of Code: https://graphite.rs/volunteer/guide/student-projects/#animation-system

This work was stalled because of the constant folding: non-async secondary inputs are all evaluated as the graph is compiled.

Possible solutions:

  • All nodes are async (no constant folding)
  • Somehow determine if nodes are actually constants.
  • Just recompile the graph each frame (as proposed by TrueDoctor in discord)

    For the animation we will need to rely on sufficiently fast compilation speeds. Incremental compilation will help as well in that regard.

Concept by Keavon Animation Panel

@0HyperCube 0HyperCube added Architecture Involves architecture or engineering work or discussion Performance Speed and efficiency improvements Graphene Involves the node graph system/engine used by Graphite labels Jan 11, 2025
@Keavon Keavon added the Feature label Jan 11, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Jan 11, 2025
@Keavon Keavon removed the Feature label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Involves architecture or engineering work or discussion Graphene Involves the node graph system/engine used by Graphite Performance Speed and efficiency improvements
Projects
Status: Short-Term
Development

No branches or pull requests

2 participants