Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch document tabs to work based on document ID not index #225

Closed
Keavon opened this issue Jun 22, 2021 · 3 comments · Fixed by #376 or #406
Closed

Switch document tabs to work based on document ID not index #225

Keavon opened this issue Jun 22, 2021 · 3 comments · Fixed by #376 or #406
Assignees
@psuong
Labels
Web Involves web programming (TypeScript, Svelte, CSS)
Milestone
Milestone 8

Comments

@Keavon
Copy link
Member

Keavon commented Jun 22, 2021

This is required for #195 and will also simplify the code, where specific complexity was introduced to make indexes work correctly with closing tabs in #215.
@Keavon Keavon added Available Web Involves web programming (TypeScript, Svelte, CSS) labels Jun 22, 2021
@Keavon Keavon added this to the Sprint 5 (current) milestone Jun 22, 2021
@akshay1992kalbhor
Copy link
Contributor

Can I work on this?

@Keavon Keavon removed the Available label Jun 22, 2021
@Keavon Keavon modified the milestones: Sprint 5, Sprint 6 (current) Jul 10, 2021
@Keavon
Copy link
Member Author

Keavon commented Jul 12, 2021

@akshay1992kalbhor I marked this again as Available but I'm keeping it assigned to you. Please let me know when you have actually started writing code (and submit a draft PR) then I'll switch Available to In-Progress. In the meantime, if anyone else wants to take this assigned issue, I'm happy to reassign it (as is the case with any issues listed as Available but assigned, that means the work has not begun yet so it can be reassigned to anyone who's interested in starting on it sooner).

@Keavon Keavon added P-Low and removed P-Medium labels Jul 12, 2021
@Keavon Keavon mentioned this issue Jul 17, 2021
Open
@Keavon Keavon mentioned this issue Aug 10, 2021
Closed
@Keavon Keavon added P-Medium and removed P-Low labels Aug 12, 2021
@psuong
Copy link
Contributor

psuong commented Sep 9, 2021

@Keavon forwarding this from the discord, to state I'd like to try this.

@psuong psuong mentioned this issue Sep 11, 2021
Merged
@mfish33 mfish33 linked a pull request Dec 18, 2021 that will close this issue
Remove all use of document indices #406
Merged
@Keavon Keavon mentioned this issue Dec 20, 2021
Closed
@0HyperCube 0HyperCube moved this to Completed This Sprint in Task Board Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psuong psuong

Labels
Web Involves web programming (TypeScript, Svelte, CSS)
Projects
Task Board
Archived in project
Milestone
Milestone 8
Development

Successfully merging a pull request may close this issue.

id-based-docs psuong/Graphite
Remove all use of document indices GraphiteEditor/Graphite
3 participants
@Keavon @psuong @akshay1992kalbhor