Closing doc tabs #215
Closing doc tabs #215
Conversation
|
akshay1992kalbhor
force-pushed
the
closing-doc-tabs
branch
from
6cd8159 to
4bbd9ac
Compare
|
At a broader scale, it would be great to switch from using indexes to document IDs. It would especially help simplify a good amount of the complexity that this PR introduces with all the fragile special cases for dealing with the shift caused by array mutation. It will be even more necessary when it comes time to implement tab rearranging. I'll let you decide if you want to refactor it now, or merge this now and you (or someone else, if you don't volunteer) can submit a followup PR to address it. I expect that followup PR would remove more lines of code than it adds, which is a very good thing (simplicity is key to maintainability). This is great work and thanks for your changes! Sorry it took a day until I was available to review. |
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 2 of 6 files at r2, 5 of 5 files at r4.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @akshay1992kalbhor)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @akshay1992kalbhor)
* Can only remove last document successfully * Correctly update the layer tree panel * Remove comments * Add support for randomly closing docs * Create new doc after closing last doc * Update layer panel when creating new docs * Fix bug that crashed the program when first doc was closed * Refactor to make code simpler and increase readability * Add shortcut to close active doc (Shift + C) * Add a confirmation dialog box before closing tabs * New docs get the correct title * Remove comments and fix typos * Disable 'eslint-no-alert' * Refactor and fix document title bug * Rename the FrontendMessage and ReponseType for showing close confirmation modal * Change the message displayed in the close confirmation modal Co-authored-by: Keavon Chambers <[email protected]>
Few notes
Closes #211.
This change is