Automatically place layers into the artboard they're drawn inside of

[james-ryans]

Part of #1507

[Keavon]

!build

[github-actions]

📦 Build Complete for 3bcefaf
https://b1dcab56.graphite.pages.dev

[Keavon]

Thanks!

[Keavon]

Hi @james-ryans, I've just discovered a regression introduced by this PR. Would you be able to work on solving it in a new PR, please? If you're not able to do so in the next few days, please let me know and I'll try to find someone else to work on it, but you're probably the most familiar with the code so it'd be great if you do have the time. Thank you!

Problem description: when a nested layer is selected, creating new shapes with the drawing tools should put the new layers alongside (as siblings of) the selected layer. The regression results in those always being drawn at the top level, just inside the artboard (if there is one, otherwise at the document root).

• Previous commit (working): https://c0363b33.graphite.pages.dev/
  Video of the intended behavior:

  capture.mp4

• This PR's commit (regression): https://3972e6b1.graphite.pages.dev/
  Video of the regression in behavior:

  capture_3_.mp4

[Keavon]

@james-ryans Hello, just checking up to see your plans. I saw you reacted to the previous message. Since this introduces a somewhat serious quality-of-life issue for drawing inside of folders, I may revert this PR within the next few days so the original feature can be re-attempted now that we know this is a regression to watch out for (which I failed to find during my initial QA tests). But I'm just commenting to see if, perhaps, you've been already working on a solution and are nearly ready to open a PR for it. In that case, I'll hold off for a few days before reverting. What's best in regards to your plans? Thank you!

[Keavon]

Turns out it wasn't overly difficult to fix, so I implemented it myself (in the commit listed in the history directly above this comment) out of concern for timing. Now I can do another production deploy so users can access an editor without this breakage again. When you have more time on your hands to keep contributing, there is plenty available, just ping me and I'm happy to assign more feature requests for you to take a look at. Thanks again for this valuable feature!