Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all use of document indices #406

Merged
merged 20 commits into from
Dec 25, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/widgets/buttons/IconButton.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<button class="icon-button" :class="`size-${String(size)}`" @click="action">
<button class="icon-button" :class="`size-${String(size)}`" @click="(e) => action(e)">
<IconLabel :icon="icon" />
</button>
</template>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/workspace/Panel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
@click.middle="(e) => e.stopPropagation() || (closeAction && closeAction(tabIndex))"
>
<span>{{ tabLabel }}</span>
<IconButton :action="(e) => closeAction && closeAction(e, tabIndex)" :icon="'CloseX'" :size="16" v-if="tabCloseButtons" />
<IconButton :action="(e) => e.stopPropagation() || (closeAction && closeAction(tabIndex))" :icon="'CloseX'" :size="16" v-if="tabCloseButtons" />
</div>
</div>
<PopoverButton :icon="PopoverButtonIcon.VerticalEllipsis">
Expand Down
4 changes: 1 addition & 3 deletions frontend/src/dispatcher/js-messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ export class UpdateInputHints extends JsMessage {
readonly hint_data!: HintData;
}

export class HintGroup extends Array<HintInfo> {}
Keavon marked this conversation as resolved.
Show resolved Hide resolved

export class HintData extends Array<HintGroup> {}
export type HintData = HintInfo[][];

export class HintInfo {
readonly keys!: string[];
Expand Down