Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewport zoom/rotation while snapping to show snapped values #663

Merged

Conversation

RahulHi
Copy link
Contributor

@RahulHi RahulHi commented May 26, 2022

The zoom and tilt inputs on the top right corner of the viewport previously did not display the correct snapped when snap zooming or snap tilting and instead displayed the precise zoom and tilt values. I changed the appropriate widget value's to use snapped_scale() and snapped_angle() to fix this.

Closes #643

…d_angle() to properly display snapped zoom and tilt values
@Keavon
Copy link
Member

Keavon commented May 26, 2022

Sure is nice when the bug fixes are simple! The less complexity, the more maintainable. Hopefully you got the chance to feel your way around the code a little bit during this endeavor!

@Keavon Keavon merged commit d4d1483 into GraphiteEditor:master May 26, 2022
RahulHi added a commit to RahulHi/Graphite that referenced this pull request May 26, 2022
@RahulHi RahulHi deleted the fix-on-going-zoom-tilt-snap-display branch May 26, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewport zoom/rotation while snapping doesn't show the snapped values
2 participants