Preserve layer stacking order on copy and paste #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Issue#610 by reversing the direction of the copy buffer entry vector. This will preserve the layer ordering and match the behaviour of PasteIntoFolder.
Keavon
approved these changes
Jun 8, 2022
Keavon
changed the title
Keavon
pushed a commit
that referenced
this pull request
Jun 16, 2022
Fix Issue#610 Fix Issue#610 by reversing the direction of the copy buffer entry vector. This will preserve the layer ordering and match the behaviour of PasteIntoFolder.
Keavon
pushed a commit
that referenced
this pull request
Jul 30, 2023
Fix Issue#610 Fix Issue#610 by reversing the direction of the copy buffer entry vector. This will preserve the layer ordering and match the behaviour of PasteIntoFolder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking into the issue, it only seems to happen when copying and pasting serialized data using
PortfolioMessage::PasteSerializedData. To fix the issue, the copy buffer entry vector in portfolio_message_handler.rs#L417 should be iterated in a reverse order.Something similar can be seen when using
PortfolioMessage::PasteIntoFolderin portfolio_message_handler.rs#L397-L405, where the iteration direction is changed based on theinsert_index. InPortfolioMessage::PasteSerializedDatatheinsert_indexis known ahead of time which allows us to simply reverse the direciton.This fix should result in
PortfolioMessage::PasteIntoFolderandPortfolioMessage::PasteSerializedDataproducing matching results.Closes #610