Fix battle in front of glowy stag god #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When fighting in front of the glowy stag god, the battle used to end when you defeated even one enemy. It turns out that QUEST_CONTENT_LUA_NOTIFY needs to track occurrences until it reaches its count variable. It doesn't always trigger on the first notice. "count"s more than 1 are rare for QUEST_CONTENT_LUA_NOTIFY.
I've added QUEST_CONTENT_LUA_NOTIFY tracking to PlayerProgress's questProgressCountMap, which I converted from a Map<Integer, Integer> to a Map<String, Integer>.
I've added rollback functionality as well.
I've tested it by failing the quest (dying) this reset the count properly. Relogging also reset the count properly. relevant sections of Act1 and act 3 are unaffected.
Type of changes
Checklist: