Make ice dude show up #2200
Merged
Make ice dude show up #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might as well fix this while I'm here. "leave" and "enter" have the same number of letters, so it works.
KingRainbow44
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENTER_REGION names are not unique. There was a hash collision between two ENTER_REGION_68's that caused ice dude to not show up in front of his domain.
Adding the group id to the name string makes them unique.
Also, there was a string.contains() when you should be using string.equals().
Issues fixed by this PR
Ice dude finally got his cocogoat milk and cigarettes and came back. (┬┬﹏┬┬)
Type of changes
Checklist: