Do not unload groups asked for by quests #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not unload groups asked for by quests due to distance.
When you are too far away from a group when QUEST_EXEC_REFRESH_GROUP_SUITE happens, the group will instantly be unloaded (after patching the error in SceneScriptManager's refreshGroupSuite) and any suite information that is different from the default will be lost.
I tried saving and loading this suite information, but that just caused the suite to keep loading even after the quest was done.
Hartie talked about saving monster, gadget, quest marker, ect whereabouts, but I think a more quick solution is to just not unload these quest exec groups in the first place.
Issues fixed by this PR
This fixes at least five bugs:
prologue act 2: tear does not appear in chest. The chest was too far away and it's default, boring contents were loaded instead.
prologue act 3: after breaking storm barrier, next quest marker doesn't load. The marker was too far away to load.
Bomber girl story quest: Enter the tavern and nothing happens. Tavern is in a different world. this means it was too far away to load the suite and keep it.
Bomber girl story quest: Nothing at the dig spot. The dig spot is way too far away from the city to load the suite and keep it.
Fire dude story quest: No attackers at the bridge. The other end of the bridge is juuust long enough to be outsize the loading zone. Hitting the trigger from the bridge side was close enough to make the suite load.
Type of changes
Checklist: