Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unlogging quests #2226

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Fix unlogging quests #2226

merged 1 commit into from
Jun 24, 2023

Conversation

scooterboo
Copy link
Contributor

Description

I couldn't use /q dubug to turn off debugging on a quest.
loggedQuests.remove() here is getting confused between

public E remove(int index)
and
public boolean remove(Object o)

because questId is an int.

Issues fixed by this PR

image

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@scooterboo
Copy link
Contributor Author

Alternatively,
loggedQuests.remove((Integer) questId);

@KingRainbow44 KingRainbow44 merged commit 9fd5f76 into Grasscutters:development Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants