Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end user license agreement girl's story quest fixes #2227

Merged
merged 1 commit into from
Jun 24, 2023
Merged

end user license agreement girl's story quest fixes #2227

merged 1 commit into from
Jun 24, 2023

Conversation

scooterboo
Copy link
Contributor

Description

Add some fixes to Script lib that came to light when doing end user license agreement girl's story quest.

Issues fixed by this PR

It was the typical nil value error for StopChallenge.
IsPlayerAllAvatarDie made the last part of the quest never finish. It would get stuck in a loop.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44 KingRainbow44 merged commit 30d093f into Grasscutters:development Jun 24, 2023
@scooterboo scooterboo deleted the patch-2 branch July 13, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants