Set event source for group variable changes to the variable name #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the resources, EVENT_VARIABLE_CHANGE has either a blank source or the source is the name of the variable. We were not saving the source name when we were making a callEvent.
Issues fixed by this PR
In upbeat spirit girl's story quest, there's a door where you need two blue spirit light actuators to open it. When the actuators were going into the lantern, the corresponding condition_EVENT_VARIABLE_CHANGE was not firing since the ScriptArgs didn't know what the variable name was. (scene 1059, group 201059002)
Type of changes
Checklist: