Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX auto skipping handbook generation when file is not found. #2300

Merged
merged 1 commit into from
Aug 25, 2023
Merged

FIX auto skipping handbook generation when file is not found. #2300

merged 1 commit into from
Aug 25, 2023

Conversation

Simplxss
Copy link
Contributor

@Simplxss Simplxss commented Aug 21, 2023 •
edited
Loading

Description

Fix can't skip generate handbook when 'src/handbook/data/commands.json', 'src/handbook/data/avatars.csv' ... are not found.

Issues fixed by this PR

#2186

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44
Copy link
Member

what is the difference in behaviors? both should behave exactly the same.

@Simplxss
Copy link
Contributor Author

Not the same, file() always return true whether the file is exist.
image

@KingRainbow44 KingRainbow44 merged commit 7e0a752 into Grasscutters:development Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingRainbow44 KingRainbow44 KingRainbow44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simplxss @KingRainbow44