Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little update to item giving handling #2363

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Little update to item giving handling #2363

merged 3 commits into from
Sep 15, 2023

Conversation

scooterboo
Copy link
Contributor

@scooterboo scooterboo commented Sep 14, 2023

Description

GIVING_METHOD_GROUP is used in cooking girl's quest
Made it so that giving packets are sent at the start of a relog.
Made it so that you don't need the exact amount of an item in your inventory. You can have more.

Issues fixed by this PR

Little update to HandlerItemGivingReq.java Allows you to give the weird ingredients to cooking girl near the end of her quest.
Send the giving packet at the start of relogs, even if encountered be… giving packets were not being sent after a relog. logic changed with magix's permission.
Make item checking not exact Allows you to submit fowl and flowers to the bartender girl in freedom city leader's story quest.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

GIVING_METHOD_GROUP is used in cooking girl's quest
@scooterboo scooterboo marked this pull request as draft September 14, 2023 13:23
@scooterboo
Copy link
Contributor Author

Actually, there's some item giving problem with quest 48902 (probably something new). I'm going to bundle in what I find the fix is.... Tomorrow.

You can have more items in your inventory than what you are submitting.
@scooterboo scooterboo marked this pull request as ready for review September 15, 2023 00:30
@scooterboo scooterboo changed the title Little update to HandlerItemGivingReq.java Little update to item giving handling Sep 15, 2023
@KingRainbow44 KingRainbow44 merged commit f955bb1 into Grasscutters:development Sep 15, 2023
@scooterboo scooterboo deleted the patch-1 branch September 15, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants