-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation and actions for View Settings #2159
Comments
zackkatz
added a commit
that referenced
this issue
Nov 7, 2024
This takes advantage of browser validation (related to #2159), while making a very small change. I considered updating the `GravityView_FieldType` abstract class to add an `input_type` and just use the existing `GravityView_FieldType_text` class, but I determined that this was cleaner.
zahardev
added a commit
that referenced
this issue
Dec 6, 2024
zahardev
added a commit
that referenced
this issue
Dec 6, 2024
zahardev
added a commit
that referenced
this issue
Dec 6, 2024
zahardev
added a commit
that referenced
this issue
Dec 6, 2024
zahardev
added a commit
that referenced
this issue
Dec 6, 2024
zahardev
added a commit
that referenced
this issue
Dec 11, 2024
zahardev
added a commit
that referenced
this issue
Dec 11, 2024
zahardev
added a commit
that referenced
this issue
Dec 17, 2024
zahardev
added a commit
that referenced
this issue
Dec 17, 2024
zahardev
added a commit
that referenced
this issue
Dec 18, 2024
zahardev
added a commit
that referenced
this issue
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the view settings do not have a validation system in place. This means the values can be basically anything, or be omitted. To have more fine grain control over the inputs, we'd need validation.
Describe the solution you'd like
required
.validate
key which supports a callback, that receives the posted value, and the rest of the settings. Basically how Gravity Forms itself handles it.action
key could be added with incremental options for the future, but at least have:clear_on_form_change
for example.This solution is just whats off the top of my head, it might be better solved.
The text was updated successfully, but these errors were encountered: