Add a product logo next to the heading #2218

[zahardev]

💾 Build file (b6dbb58).

[zackkatz]

@zahardev Please add a comment about why -20px is what is being used, just to make it clear for future people. I assume it's admin-content padding.

[zahardev]

@zackkatz Done!

[mrcasual]

@zahardev, looks good, thanks! While you're at it, could you also please dequeue notices and remove the footer, just like in GravityCalendar and GravityCharts?

[zahardev]

@mrcasual Sure, will be done.
Did you notice the failed tests BTW? I believe they’re unrelated to the PR. Didn’t investigate it deeply, but it seems the issue might be caused by a change in the date format:

1. GVCommon_Test::test_format_date
   Failed asserting that two strings are equal.
   --- Expected
   +++ Actual
   @@ @@
   -'4 weeks ago'
   +'4 weeks from now'

[mrcasual]

@mrcasual Sure, will be done. Did you notice the failed tests BTW? I believe they’re unrelated to the PR. Didn’t investigate it deeply, but it seems the issue might be caused by a change in the date format:

1. GVCommon_Test::test_format_date
   Failed asserting that two strings are equal.
   --- Expected
   +++ Actual
   @@ @@
   -'4 weeks ago'
   +'4 weeks from now'

@zahardev, this is a flaky test that usually works but not always. It's on our to-do list (prior attempts to consistently reproduce it for a fix have failed). If you're willing to help, we'd appreciate it.

[zahardev]

@zahardev, this is a flaky test that usually works but not always. It's on our to-do list (prior attempts to consistently reproduce it for a fix have failed). If you're willing to help, we'd appreciate it.

@mrcasual If you have failed to reproduce it, I'm not sure I can succeed at it, but I can try :) Do you want me to check this out after the CSV issue is complete, or just add it to my to-do list with low priority?

[mrcasual]

@zahardev, to be honest, we didn't spend much time on this. If I recall correctly, this test was introduced or started failing after this commit. It happens once in a blue moon, but eventually, we need to resolve it. Feel free to add it to your to-do list and address it when you have a chance.