2224 settings UI issues #2227
2224 settings UI issues #2227
Conversation
|
@Mwalek, please test with DataTables, Maps, Ratings & Reviews, etc. |
|
@mrcasual @zahardev I tested this and confirmed that the layout no longer breaks when there are long form names. However, I found a couple of issues related to the alternating colors (zebra stripes). The common issue across nearly every settings tabs is that there are no zebra stripes until the first click (change to settings). Ratings & Reviews: When the default option "5-Star Rating" for Review type is selected, the fields below do not have zebra stripes. 
DataTables: Zebra stripes are not always implemented correctly. E.g. when "Enable Buttons" is clicked. 
|
|
@zahardev, could you please resolve the merge conflicts? |
|
@mrcasual Done, and also added an enhancement for slow browsers. |
| }); | ||
| $trs.filter( ':even' ).addClass( 'alternate' ); | ||
| } ); | ||
| }, 50 ); |
There was a problem hiding this comment.
@zahardev, why this magic number? Will it work in every situation?
There was a problem hiding this comment.
@mrcasual We need to allow the browser some time to render the DOM before applying zebra stripes. However, this time should be short enough that users don’t notice the visual change when rows initially load without zebra stripes, and then the stripes are applied. Probably we could reduce it to 20 milliseconds, but I’m afraid that slower browsers might not have enough time to fully render the DOM.
Implements #2224
💾 Build file (609641b).