Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update netty-handler to latest version 4.1.59.Final #52

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

danotorrey
Copy link
Contributor

@danotorrey danotorrey commented Mar 2, 2021

Update the netty-handler dependency to 4.1.59.Final. This resolves an important CVE as mentioned in #50. I'm not sure why Dependabot did not pick up the later version, so this PR was filed.

@danotorrey danotorrey changed the title Update netty-handler to latest version Update netty-handler to latest version 4.1.59.Final Mar 2, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.732% when pulling a59c051 on netty-update into a02819a on master.

@danotorrey
Copy link
Contributor Author

I smoke-tested the UDP and TCP GELF transports, and they seem to work. Also, a review of the Netty change log looks ok as far as I can see.

@danotorrey danotorrey requested a review from bernd March 2, 2021 14:29
@bernd bernd self-assigned this Mar 2, 2021
@bernd bernd merged commit 4e5b607 into master Mar 2, 2021
@bernd bernd deleted the netty-update branch March 2, 2021 14:33
@danotorrey
Copy link
Contributor Author

@bernd Shall we cut a release of the gelfclient now that we've updated the Netty version? I don't see any other issues or PRs that we'd want to get it urgently. So, perhaps now makes sense unless we have plans to do it at some point later.

@bernd
Copy link
Member

bernd commented Mar 3, 2021

@danotorrey We can do that, yes. 👍 Can you talk to @juju2112 about automating the release process including pushing the artifacts to maven central?

@danotorrey
Copy link
Contributor Author

@bernd Will do. Thanks.

@danotorrey
Copy link
Contributor Author

@juju2112 will be looking at doing the gelfclient release sometime in the next weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants