Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create input with togglable masking #168

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Create input with togglable masking #168

merged 1 commit into from
Aug 2, 2019

Conversation

kyleknighted
Copy link
Contributor

@kyleknighted kyleknighted commented Jul 26, 2019 •
edited
Loading

Create an input that have be toggled to display text or mask it such as a password.

image

image

Closes #104

danotorrey
danotorrey approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@danotorrey danotorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from what I can tell of the code. Also works great 👍

cobaltclaudia
cobaltclaudia approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@cobaltclaudia cobaltclaudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Very cool!

kmerz
kmerz approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@kmerz kmerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@kmerz kmerz merged commit cbf7afe into aws Aug 2, 2019
@kmerz kmerz deleted the aws_secret_toggle_masking branch August 2, 2019 08:46
@kyleknighted kyleknighted mentioned this pull request Aug 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmerz kmerz kmerz approved these changes

@danotorrey danotorrey danotorrey approved these changes

@cobaltclaudia cobaltclaudia cobaltclaudia approved these changes

@edmundoa edmundoa Awaiting requested review from edmundoa

Assignees
No one assigned
Labels
aws ready-for-review ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyleknighted @kmerz @danotorrey @cobaltclaudia