Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinesis-related code cleanup #54

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Kinesis-related code cleanup #54

merged 2 commits into from
Jun 5, 2019

Conversation

danotorrey
Copy link
Contributor

Kinesis cleanup:

  • Remove unneeded method
  • Increase max # of Kinesis pages that can be pulled from 100 to 1000. This is a max limit to prevent potential infinite loop.
  • Use underscore_case instead of cammelCase for JSON properties. Generally in Graylog we use underscores.

Dan Torrey added 2 commits June 4, 2019 16:43
Increase max retry limit for stream get to 1000
d164bce 
Runaway looping Stopping at 100 is probably to small.
Use underscores instead of camel case for json names
a40be08 
It is a general project standard to use underscores.
@danotorrey danotorrey requested a review from cobaltclaudia June 4, 2019 21:53
cobaltclaudia
cobaltclaudia approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@cobaltclaudia cobaltclaudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cobaltclaudia cobaltclaudia merged commit 4931756 into aws-backend Jun 5, 2019
@cobaltclaudia cobaltclaudia deleted the kinesis-json-code-cleanup branch June 5, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cobaltclaudia cobaltclaudia cobaltclaudia approved these changes

Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danotorrey @cobaltclaudia