Form Field Validation #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknighted
force-pushed
the
form_validation
branch
from
56eba91 to
898d2ef
Compare
kyleknighted
force-pushed
the
form_validation
branch
from
898d2ef to
f50acdc
Compare
kyleknighted
commented
Jul 10, 2019
| @@ -2,12 +2,12 @@ import React, { useContext } from 'react'; | |||
|
|
|||
| import Wizard from 'components/common/Wizard'; | |||
| import FormUtils from 'util/FormsUtils.js'; | |||
| import formValidation from 'utils/formValidation'; | |||
There was a problem hiding this comment.
Maybe this stuff moves to core FormUtils?
danotorrey
requested changes
Jul 10, 2019
danotorrey
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
Looks good to @ceruleancee and I.
Only one thing we noticed (not a big deal right now): The API Key and API Secret accept values with just spaces. Should it be doing a not blank check there (require a value with non-space chars)? We can also just take care of this later.
cobaltclaudia
approved these changes
Jul 11, 2019
dennisoelkers
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides help message and validation to each field.
Could add a list of errors at the top of the form as well, but this should work for the time being.
Feel free to share anything that may already exist for field validation.