Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I am the funny special char and break the whole system #28

Closed
lennartkoopmann opened this issue Feb 24, 2011 · 7 comments
Closed

I am the funny special char and break the whole system #28

lennartkoopmann opened this issue Feb 24, 2011 · 7 comments

Comments

@lennartkoopmann
Copy link
Contributor

Not only reserved words break mongo_mapper but also special characters like '-' or '/'. Let's finally fix this stupid issue.
@aedocw
Copy link

aedocw commented Mar 9, 2011

I don't think this is a server problem - I'm sending funny special chars in my GELF messages and the server is ingesting them just fine. However, any time the web interface tries to render messages, it dies. SO shouldn't this be files under web-interface instead?

@lennartkoopmann
Copy link
Contributor Author

You are right but this is filed in the server because I am thinking of skipping every field that is not alphanumeric when received by the server.

@aedocw
Copy link

aedocw commented Mar 14, 2011

Meaning special characters other than "_" will not be allowed in GELF
messages? If I need to change the labels, please let me know so I can
do that as soon as possible. We're currently using Graylog2 server to
aggregate stats for around 20 servers. Just want to make sure we're
doing this right going forward.

-Christopher

On Sun, Mar 13, 2011 at 3:42 PM, lennartkoopmann
[email protected]
wrote:

You are right but this is filed in the server because I am thinking of skipping every field that is not alphanumeric when received by the server.

#28 (comment)

@lennartkoopmann
Copy link
Contributor Author

Yes. That's what I'd suggest for now to keep things easy.

@lusis
Copy link

lusis commented Mar 31, 2011

@lennartkoopmann is the following error indicative of this issue?

Exception in thread "pool-1-thread-261" java.lang.NumberFormatException: For input string: "-127-76"
    at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
    at java.lang.Integer.parseInt(Integer.java:458)
    at java.lang.Integer.parseInt(Integer.java:499)
    at org.graylog2.messagehandlers.gelf.GELFHeader.extract(GELFHeader.java:84)
    at org.graylog2.messagehandlers.gelf.GELFHeader.getSequenceCount(GELFHeader.java:136)
    at org.graylog2.messagehandlers.gelf.ChunkedGELFClientHandler.<init>(ChunkedGELFClientHandler.java:58)
    at org.graylog2.messagehandlers.gelf.GELFClientHandlerThread.run(GELFClientHandlerThread.java:55)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:662)
Exception in thread "pool-1-thread-980" java.lang.NumberFormatException: For input string: "-23-8"
    at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
    at java.lang.Integer.parseInt(Integer.java:458)
    at java.lang.Integer.parseInt(Integer.java:499)
    at org.graylog2.messagehandlers.gelf.GELFHeader.extract(GELFHeader.java:84)
    at org.graylog2.messagehandlers.gelf.GELFHeader.getSequenceCount(GELFHeader.java:136)
    at org.graylog2.messagehandlers.gelf.ChunkedGELFClientHandler.<init>(ChunkedGELFClientHandler.java:58)
    at org.graylog2.messagehandlers.gelf.GELFClientHandlerThread.run(GELFClientHandlerThread.java:55)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:662)

@lennartkoopmann
Copy link
Contributor Author

@lusis no, this is another issue: this means that you tried to send in a chunked GELF message with more than 128 chunks. that is not supported. the libraries should limit that and the server should throw a more explanatory message. :)

@lennartkoopmann
Copy link
Contributor Author

Duplicate ticket in JIRA. The GitHub issue tracker is begin closed.

@2fa 2fa mentioned this issue Dec 21, 2015
Closed
joschi added a commit that referenced this issue Feb 13, 2018
@joschi @bernd
Migrate to Netty 4.1 (#28)
5249012 
* Migrate to Netty 4.1

* avoid creating a pooled buffer copy inside the aggregator method

the buffer slice in question will be copied anyway, and for some reason
creating the copy sometimes triggered a buffer leak warning although nothing seems to be wrong
joschi added a commit that referenced this issue Feb 13, 2018
@joschi @bernd
Replace usage of ChannelBuffer with ByteBuf in NetFlowV9HeaderTest (#29)
d03f677 
This occurrence of ChannelBuffer was missed in the original Netty 4 PR (#28)
joschi pushed a commit that referenced this issue Feb 13, 2018
@edmundoa @joschi
Enrich messages with country code and city name (#28)
79baf17 
This commit enriches messages with the ISO country code and city name, if
there is geo information of an IP address. They will be saved in the
corresponding `<fieldname>_country_code` and `<fieldname>_city_name` fields.

Closes #10
joschi pushed a commit that referenced this issue Feb 15, 2018
@kroepke
IpAddressConversion caught wrong exception (#32)
2025d36 
The first try block caught a too specific version of the IllegalArgumentException, allowing the exception to unwind too much. Properly return null or the default value in this case.

Fixes #28
(cherry picked from commit fc5b8a543f47ba85f9e9e65b98ddca3066994602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lennartkoopmann @lusis @aedocw