Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.protobuf:protobuf-bom from 3.25.5 to 3.25.6 #21446

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 27, 2025

Bumps com.google.protobuf:protobuf-bom from 3.25.5 to 3.25.6.

Commits
  • dd4c8a7 Updating version.json and repo version numbers to: 25.6
  • 3f1df78 Add poison pill to makeExtensionsImmutable method (#20084)
  • 156b87b Merge pull request #19952 from honglooker/25.x
  • c6fcd39 Fixed compiler warnings in the Ruby C extension.
  • 028200c Update artifact actions (#19701)
  • e2cc170 Remove CMake downgrade workaround from Windows CI tests (#19633)
  • 65196bc Backport windows fixes with INFINITY/NAN (#19390)
  • c30f726 Merge pull request #18974 from protocolbuffers/cp-25-backport-macos
  • 3f26684 Upgrade setup-ruby to get around 'Unsupported platform macos-13'
  • 5f9e57b Remove continous-only tag which didn't exist in 25.x
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
com.google.protobuf:protobuf-bom [>= 4.a, < 5]

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.25.5 to 3.25.6.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](protocolbuffers/protobuf@v3.25.5...v3.25.6)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file maven labels Jan 27, 2025
@thll thll self-assigned this Jan 28, 2025
@thll
Copy link
Contributor

thll commented Jan 28, 2025

We've swallowed the poison pill introduced in protocolbuffers/protobuf#20084. From the build failure:

RawMessageTest.minimalEncodeDecode:39 » UnsupportedOperation As of 2022/09/29 (release 21.7) makeExtensionsImmutable should not be called from protobuf gencode. If you are seeing this message, your gencode is vulnerable to a denial of service attack. You should regenerate your code using protobuf 25.6 or later. Use the latest version that meets your needs. However, if you understand the risks and wish to continue with vulnerable gencode, you can set the system property -Dcom.google.protobuf.use_unsafe_pre22_gencode on the command line. See security vulnerability: GHSA-h4h5-3hr4-j3g2

Recompiling our .proto files with protoc version 25.6 fixes that.

@thll thll requested review from bernd and kroepke January 29, 2025 10:41
@thll thll removed their assignment Jan 31, 2025
@bernd bernd merged commit e656082 into master Feb 3, 2025
6 checks passed
@bernd bernd deleted the dependabot/maven/com.google.protobuf-protobuf-bom-3.25.6 branch February 3, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants