Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded cypress and debugged mapTools.js #102

Merged
merged 1 commit into from
Sep 13, 2021
Merged

upgraded cypress and debugged mapTools.js #102

merged 1 commit into from
Sep 13, 2021

Conversation

vishal5251
Copy link
Contributor

I had upgraded the cypress version and debugged the mapTool.js (path: C:\Users\Vishal\Documents\GitHub\treetracker-wallet-web\src_old\mapTools.js).

@dadiorchen
Copy link
Collaborator

@vishal5251 thanks for you work! bty, are you in the slack channel?

@vishal5251
Copy link
Contributor Author

nope..

// with the any changed environment variables
return config
}
module.exports = (on, config) => {};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishal5251 can you double check this change, the line require('@cypress/react/plugins/react-scripts')(on, config) is for the cypress component tool, after deleting this line, does the component tool works? https://github.com/Greenstand/treetracker-wallet-web#how-to-build-a-component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadiorchen Yes, I commented the line and it still it works.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thank you for you contribution.

@dadiorchen
Copy link
Collaborator

nope..

We have a community on slack, if you like you can leave you email here or send it to me so we can invite you to join the community!

@vishal5251
Copy link
Contributor Author

[email protected] this is my gmail account.

@dadiorchen dadiorchen merged commit 9ceb138 into Greenstand:master Sep 13, 2021
@vishal5251 vishal5251 deleted the upgradeCypress branch September 13, 2021 08:53
@vishal5251 vishal5251 restored the upgradeCypress branch September 14, 2021 08:35
@pvdo
Copy link

pvdo commented Sep 16, 2021

image

I am not much familiar with Cypress. @vishal5251 Do you know how to fix this issue?

@dadiorchen
Copy link
Collaborator

@pvdo did you try to restore these lines:

module.exports = (on, config) => {
  // `on` is used to hook into various events Cypress emits
  // `config` is the resolved Cypress config

  // copy from https://github.com/cypress-io/cypress/tree/master/npm/react
  require('@cypress/react/plugins/react-scripts')(on, config)
  // IMPORTANT to return the config object
  // with the any changed environment variables
  return config 

@pvdo
Copy link

pvdo commented Sep 17, 2021

That actually works! I should have done that 😑
Thanks @dadiorchen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants