Fix Fluid Drilling Rig sometimes drilling on the incorrect vein #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fluid drills now drill the correct fluid when close to fluid vein borders and one or more coordinate is negative
Implementation Details
Uses
Math.floorDivinstead of integer divisionOutcome
Fluid drill now works
Additional Information
The prospectors do not seem to have the same issue
Potential Compatibility Issues
Existing fluid drills in the "bugged" state will try to get their amount and deplete from the wrong vein, users need to break and replace their fluid drills