-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sound System to GTCEu #234
Conversation
src/main/java/gregtech/api/metatileentity/SimpleGeneratorMetaTileEntity.java
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/sound/PositionedSoundMTE.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/capability/impl/AbstractRecipeLogic.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/sound/ISoundCreator.java
Outdated
Show resolved
Hide resolved
2902616
to
aecdec0
Compare
|
|
After careful reading I found that I was negligent, please ignore the comments above. I think it can be merged as soon as coremod issues be solved, and it worked fine when I tested it. really nice stuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we add a few lines of classbytes, I don't know why other jump operators (e.g. goto) aren't broken, I remember should recalculating the position of the jump label. Probably my ASM learning is not in place, anyway its fine as long as it can run correctly. The final point is that there is no sound when using the wrench adjust the front face.
Adds sounds to the specifications of issue #221.