Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements to GT Module Code #2736

Merged
merged 8 commits into from
Feb 25, 2025
Merged

Conversation

TechLord22
Copy link
Member

What

Makes some general improvements to the GT Module code.

  1. Adds annotations to method signatures and some fields to improve nullity clarity
  2. Uses clazz.getConstructor().newInstance() instead of clazz.newInstance(), since it's deprecated in Java 9, and can throw hidden checked exceptions previously not accounted for.
  3. Fixes a bug where the last active module container is treated as active between initialization events, and indefinitely after the last event.
  4. Improves some error messages for improper module API usage.
  5. Makes some other general code improvements, such as using FastUtil collections.

Outcome

Improves GT Module related code.

@TechLord22 TechLord22 requested a review from a team as a code owner February 25, 2025 22:24
@TechLord22 TechLord22 added the type: refactor Suggestion to refactor a section of code label Feb 25, 2025
@TechLord22 TechLord22 merged commit a4cfe49 into master Feb 25, 2025
3 checks passed
@TechLord22 TechLord22 deleted the tc/modules-cleanup branch February 25, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants