Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add decomposition recipe division #33

Merged
merged 3 commits into from
Jul 16, 2021
Merged

add decomposition recipe division #33

merged 3 commits into from
Jul 16, 2021

Conversation

TechLord22
Copy link
Member

This PR adds division for decomposition recipes. There are very few divisible recipes in GTCE, but Realgar and Phosphorus Pentoxide are good ones to check. The duration is divided accordingly. Fluid input decomposition recipes are not reduced, as they all go off of 1000mB input amounts.

@TechLord22 TechLord22 requested a review from serenibyss July 15, 2021 00:22
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this logic LGTM. One comment (other than the possible performance increase): we should be on the lookout for other materials that are handled manually currently/could use decomp recipes to utilize this code more

@TechLord22 TechLord22 merged commit b083161 into master Jul 16, 2021
@TechLord22 TechLord22 deleted the decomposition branch July 16, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants