-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primitive Water Pump #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechLord22
requested changes
Jul 18, 2021
.../java/gregtech/common/metatileentities/electric/multiblockpart/MetaTileEntityFluidHatch.java
Show resolved
Hide resolved
.../java/gregtech/common/metatileentities/electric/multiblockpart/MetaTileEntityFluidHatch.java
Show resolved
Hide resolved
} else { | ||
return 100; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to do this based off of Biome Temperature? This would give it more compat with other biome mods that utilize the biome temperature system, like Arid or Temperate, etc.
src/main/java/gregtech/common/metatileentities/multi/MetaTileEntityPumpHatch.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR introduces the Primitive Water Pump, a multiblock from Impact which can be made before having any Steam Machines, requiring only Wood, Iron, Cobblestone, and hand tools to make.
It generates Water at a constant rate, once per second, with the amount following the formula:
Exact details can be found on the link above, as I copied the values directly for our implementation. I can change them if we feel they should be modified.