Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ore Rework #371

Merged
merged 23 commits into from
Dec 23, 2021
Merged

Ore Rework #371

merged 23 commits into from
Dec 23, 2021

Conversation

serenibyss
Copy link
Member

This PR:

  • Remakes veins entirely, mostly following the GT5u veins, and using the new Layered vein generation from GT5 vein generator #369
  • Completely rebalances ore processing, favoring the Thermal Centrifuge significantly more than before
  • Culls a handful of unused Materials, and many more unneeded ore() calls on materials
  • Buffs the Platinum process by cutting the Nitric Acid amount to process Purified Ore significantly, and adding several new ores that can make PGS
  • Reworks the Ore Byproduct page from the ground up (Rework ore byproduct page #370), following the pattern of the Material Tree page from Material Tree JEI page returns #66
  • Fixes a bug with ore vein layer generation and density in the new Layered system when multiple veins (or worldgen features) are generated in one chunk
  • Adds Gems to many more materials

This is currently a draft PR, as there are still things to do (primarily around Gems and gem IconSets), but much of this PR is already reviewable.

The Ore Byproduct change has already been reviewed as a separate PR, so its changes do not need significant review.

@serenibyss serenibyss added the status: high priority Issue or PR should be prioritized for reviews label Dec 19, 2021
@Syrcan
Copy link
Contributor

Syrcan commented Dec 19, 2021

Sheldonite PGS recipe giving out sulfuric nickel solution is very cursed, and certainly not worth it over directly smelting it to Platinum.

@Syrcan
Copy link
Contributor

Syrcan commented Dec 19, 2021

I want to propose changes to the byproducts processing. This suggestion does not alter output quantities, but it shuffles materials around. Current byproducts are sorted like this:

Main Byproduct:
Macerator:    Ore         -> Crushed
Washer:       Crushed     -> Purified Crushed
Macerator:    Crushed     -> Impure
Centrifuge:   Impure      -> Dust

Second Byproduct:
Macerator:    P.Crushed   -> P.Dust
T.Centrifuge: Crushed     -> Centrifuged
Centrifuge:   P.Dust      -> Dust

Third Byproduct:
Macerator:    Centrifuged -> Dust

Fourth Byproduct:
Bath:         Crushed     -> P.Crushed (if applicable)

(Note: if byproducts are missing, the step shifts up causing the machine to output the previous byproduct instead)
This causes awkward situations for the 3rd and 4th byproducts, on top of having the 2nd byproduct dominate over the 1st byproduct if 3rd is absent. This is my suggestion:

Main Byproduct:
Macerator:    Ore         -> Crushed
Washer:       Crushed     -> Purified Crushed
Bath:         Crushed     -> P.Crushed        (moved from 4th)
Macerator:    Centrifuged -> Dust             (moved from 3rd)
Centrifuge:   Impure      -> Dust

Second Byproduct:
T.Centrifuge: Crushed     -> Centrifuged
Centrifuge:   P.Dust      -> Dust

Third Byproduct:
Macerator:    Crushed     -> Impure           (moved from 1st)
Macerator:    P.Crushed   -> P.Dust           (moved from 2nd)

(Note: the 4th byproduct removal has been done because it felt very awkward to be in the chemical bath only, but it is the least important part of this rework)
This restores the 1st byproduct to be the primary output as it should be. The 3rd byproduct remains HV locked, but moves out of the "main" chain, which creates an interesting divergence in my opinion.

Enough said, some illustrations:

Ruby - Before
Ruby - Before
Ruby - After
Ruby - After

Redstone - Before
Redstone - Before
Redstone - After
Redstone - After

Chalcopyrite - Before
Chalcopyrite - Before
Chalcopyrite - After
Chalcopyrite - After

@Syrcan
Copy link
Contributor

Syrcan commented Dec 19, 2021

Another suggestion, somewhat controversial this time around, has to do with ores giving out different dust amounts.
As the issue has been brought up several times, it is known that ores with more dust output become ridiculous for their byproducts, as well as increase the processing time significantly. I can foresee three possible approaches to remedy this.

Approach 1:
Do nothing (BAD!!)

Approach 2:
Make recipe duration inversionally proportional to the ore multiplier amount. This fixes processing time.
Nerf the secondary output, again inversionally proportional, by introducing chanced output where necessary. This fixes some ores being OP at giving more byproducts than their actual ore material.
Example: 200L water + 1 crushed redstone -> 1 purified crushed redstone + 60% tiny pile of cinnabar (4sec duration instead of 20)
There exists an alternate version of this approach which is more of a compromise. It is done by rounding up the amount of tiny dusts in ore washer/thermal centrifuge to avoid dealing with weird percentages, and still applying the chanced output to centrifuge.
Example: 200L water + 1 crushed redstone -> 1 purified crushed redstone + 1 tiny pile of cinnabar (4sec duration instead of 20)

Approach 3:
Adjust main input and output of recipes to be multiplied by the ore multiplier amount. This is somewhat cursed, but also the easiest to implement and arguably the most balanced approach.
Example: 1000L water + 5 crushed redstone -> 5 purified crushed redstone + 3 tiny piles of cinnabar (duration unchanged)

@serenibyss serenibyss marked this pull request as ready for review December 23, 2021 05:49
@serenibyss serenibyss merged commit 4b4fb1e into master Dec 23, 2021
@serenibyss serenibyss deleted the ore-work branch December 23, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: high priority Issue or PR should be prioritized for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants