Detach Ore Prefixes from Meta Items #43
Merged
+1,592
−1,914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htmlcsjs
changed the title
TechLord22
requested changes
Jul 20, 2021
src/main/java/gregtech/api/pipenet/block/material/BlockMaterialPipe.java
Outdated
Show resolved
Hide resolved
TechLord22
approved these changes
Jul 20, 2021
Irgendwer01
suggested changes
Jul 21, 2021
remove the `IPipeType<NodeDataType>` from the generic signature once item pipes are done, as the unimplemented Inventory Pipes are the only reason why it needs both `IPipeType` and `IMaterialPipeType` right now
brachy84
approved these changes
Jul 22, 2021
serenibyss
approved these changes
Jul 22, 2021
TechLord22
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detaches ore prefixes from meta items.
Consequently it expands the material ID limit to 32767.
Other changes are: