Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review string comparisons in expression parsing #1713

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

danielcweber
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.54%. Comparing base (08a1aa1) to head (03b6f98).
Report is 4 commits behind head on 12.x.

Files with missing lines Patch % Lines
src/Core/Extensions/ExpressionExtensions.cs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             12.x    #1713      +/-   ##
==========================================
- Coverage   82.55%   82.54%   -0.02%     
==========================================
  Files         254      254              
  Lines        6852     6856       +4     
  Branches     1485     1486       +1     
==========================================
+ Hits         5657     5659       +2     
- Misses        543      545       +2     
  Partials      652      652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielcweber danielcweber merged commit 03b6f98 into 12.x Aug 28, 2024
4 checks passed
@danielcweber danielcweber deleted the ReviewStringComparisons branch August 28, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant