Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: schedule_job and interval #231

Merged
merged 27 commits into from
Sep 13, 2022
Merged

feat: schedule_job and interval #231

merged 27 commits into from
Sep 13, 2022

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Sep 7, 2022

  • add schedule job which execute repeatly using a given std::time::Duration
  • add interval which take a time array and a data array, apply a function on data array group by certain duration of time array and return function results as a PyVector, also add it in python side mock module.
  • add back test code for builtin function in python module which was somehow lost in refactor: refactor: python modules #186
  • prev now return None for the first element in vector

@discord9 discord9 marked this pull request as ready for review September 8, 2022 08:23
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #231 (9b2d17f) into poc/python-udf (e605cd0) will increase coverage by 4.10%.
The diff coverage is 83.45%.

@@                Coverage Diff                 @@
##           poc/python-udf     #231      +/-   ##
==================================================
+ Coverage           78.67%   82.77%   +4.10%     
==================================================
  Files                 161      269     +108     
  Lines                8053    21131   +13078     
==================================================
+ Hits                 6336    17492   +11156     
- Misses               1717     3639    +1922     
Flag Coverage Δ
rust 82.77% <83.45%> (+4.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/client/src/error.rs 0.00% <0.00%> (ø)
src/cmd/src/lib.rs 100.00% <ø> (ø)
src/common/function/src/scalars/math/mod.rs 100.00% <ø> (ø)
src/common/function/src/scalars/math/pow.rs 88.09% <ø> (+2.38%) ⬆️
src/common/function/src/scalars/numpy/clip.rs 94.06% <ø> (ø)
src/common/function/src/scalars/numpy/mod.rs 100.00% <ø> (ø)
src/common/grpc/src/error.rs 0.00% <0.00%> (ø)
src/common/recordbatch/src/error.rs 0.00% <0.00%> (ø)
src/common/runtime/src/lib.rs 100.00% <ø> (ø)
src/common/telemetry/src/logging.rs 84.37% <ø> (ø)
... and 272 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@killme2008
Copy link
Contributor

@discord9 test failure

@discord9
Copy link
Contributor Author

discord9 commented Sep 9, 2022

@discord9 test failure
failures:

failures:

---- sst::parquet::tests::test_parquet_writer stdout ----
thread 'sst::parquet::tests::test_parquet_writer' panicked at 'called `Result::unwrap()` on an `Err` value: ExternalFormat("Invalid Parquet file. Corrupt footer")', src/storage/src/sst/parquet.rs:319:88

@killme2008
Copy link
Contributor

Ok, i will re-run the test. But please pay attention to the PR status if you want other people review it.

@discord9 discord9 requested a review from killme2008 September 9, 2022 02:57
component/script/python/test.py Outdated Show resolved Hide resolved
src/script/Cargo.toml Outdated Show resolved Hide resolved
src/script/Cargo.toml Outdated Show resolved Hide resolved
src/script/src/engine.rs Outdated Show resolved Hide resolved
src/script/src/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/builtins/mod.rs Show resolved Hide resolved
src/script/src/python/builtins/mod.rs Outdated Show resolved Hide resolved
src/script/src/python/builtins/mod.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
src/script/src/python/engine.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit bf138a0 into poc/python-udf Sep 13, 2022
@killme2008 killme2008 deleted the feat/py_timer branch September 13, 2022 11:49
@killme2008 killme2008 restored the feat/py_timer branch September 13, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants