-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(greptimedb-operator): bump greptimedb-operator version to v0.1.3 #206
chore(greptimedb-operator): bump greptimedb-operator version to v0.1.3 #206
Conversation
WalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (1)
Line range hint
1-3093
: The CRD structure follows Kubernetes best practices.The CustomResourceDefinition is well-structured with:
- Proper API versioning (v1alpha1)
- Comprehensive schema validation
- Status subresource for Kubernetes conventions
- Proper use of OpenAPI v3 schema validation
Consider the following for future improvements:
- Add conversion webhooks for future API versions
- Include examples in the CRD for better user experience
- Consider adding defaulting webhooks for common configurations
Also applies to: 3108-3644
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
charts/greptimedb-operator/Chart.yaml
(1 hunks)charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml
(2 hunks)charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml
(1 hunks)charts/greptimedb-operator/values.yaml
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- charts/greptimedb-operator/Chart.yaml
- charts/greptimedb-operator/values.yaml
🔇 Additional comments (2)
charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (2)
18330-18343
: LGTM: Azure Blob Storage configuration schema looks good
The schema for Azure Blob Storage configuration follows Kubernetes API conventions and properly defines required fields (container, root) and optional fields (endpoint, secretName).
18554-18567
: Note: Intentional duplication of Azure Blob Storage configuration
This is an intentional duplication of the Azure Blob Storage configuration schema, allowing separate storage configuration for monitoring and main data components. The schema is consistent with the previous definition.
Wait for: https://github.com/GreptimeTeam/greptimedb-operator/actions/runs/12027395016/job/33528345744
Summary by CodeRabbit
Release Notes
New Features
azblob
,gcs
,oss
,s3
) in theGreptimeDBCluster
andGreptimeDBStandalone
configurations.datanode
,flownode
, andfrontend
components in theGreptimeDBCluster
.Version Updates
appVersion
and Docker image tag to reflect stable versioning (0.1.3
).0.2.13
.These enhancements improve flexibility and operational capabilities for users managing GreptimeDB clusters.