Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(greptimedb-operator): bump greptimedb-operator version to v0.1.3 #206

Merged

Conversation

daviderli614
Copy link
Member

@daviderli614 daviderli614 commented Nov 26, 2024

Wait for: https://github.com/GreptimeTeam/greptimedb-operator/actions/runs/12027395016/job/33528345744

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced support for various object storage backends (azblob, gcs, oss, s3) in the GreptimeDBCluster and GreptimeDBStandalone configurations.
    • Enhanced status reporting for datanode, flownode, and frontend components in the GreptimeDBCluster.
  • Version Updates

    • Updated appVersion and Docker image tag to reflect stable versioning (0.1.3).
    • Incremented chart version to 0.2.13.

These enhancements improve flexibility and operational capabilities for users managing GreptimeDB clusters.

Copy link
Contributor

coderabbitai bot commented Nov 26, 2024

Walkthrough

The pull request includes updates to the greptimedb-operator Helm chart, specifically modifying the Chart.yaml to reflect version changes, removing the alpha designation from appVersion and incrementing the version field. Additionally, the CustomResourceDefinitions (CRDs) for GreptimeDBCluster and GreptimeDBStandalone have been enhanced by adding a new objectStorage property to support various cloud storage backends. The status section of the GreptimeDBCluster CRD has also been updated to include new properties for tracking replicas.

Changes

File Change Summary
charts/greptimedb-operator/Chart.yaml Updated appVersion from 0.1.3-alpha.8 to 0.1.3; incremented version from 0.2.12 to 0.2.13.
charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml Added objectStorage property under spec with support for azblob, gcs, oss, and s3; updated status to include datanode, flownode, and frontend tracking readyReplicas and replicas; added etcdEndpoints under meta.
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml Added objectStorage property under spec with support for azblob, gcs, oss, and s3.
charts/greptimedb-operator/values.yaml Updated image tag from v0.1.3-alpha.8 to v0.1.3.
charts/greptimedb-operator/README.md Updated version from 0.2.12 to 0.2.13 and appVersion from 0.1.3-alpha.8 to 0.1.3; updated image tag to v0.1.3.

Possibly related PRs

Suggested reviewers

  • zyy17

Poem

🐇 In the meadow where the data flows,
A new version of GreptimeDB grows.
With storage options, oh so bright,
Our clusters now take flight!
From alpha to stable, we leap with glee,
Hopping along, as happy as can be! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between eff6bb0 and f3038af.

📒 Files selected for processing (1)
  • charts/greptimedb-operator/README.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • charts/greptimedb-operator/README.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@daviderli614 daviderli614 marked this pull request as ready for review November 26, 2024 09:30
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (1)

Line range hint 1-3093: The CRD structure follows Kubernetes best practices.

The CustomResourceDefinition is well-structured with:

  • Proper API versioning (v1alpha1)
  • Comprehensive schema validation
  • Status subresource for Kubernetes conventions
  • Proper use of OpenAPI v3 schema validation

Consider the following for future improvements:

  1. Add conversion webhooks for future API versions
  2. Include examples in the CRD for better user experience
  3. Consider adding defaulting webhooks for common configurations

Also applies to: 3108-3644

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 184a6bf and eff6bb0.

📒 Files selected for processing (4)
  • charts/greptimedb-operator/Chart.yaml (1 hunks)
  • charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (2 hunks)
  • charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (1 hunks)
  • charts/greptimedb-operator/values.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • charts/greptimedb-operator/Chart.yaml
  • charts/greptimedb-operator/values.yaml
🔇 Additional comments (2)
charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (2)

18330-18343: LGTM: Azure Blob Storage configuration schema looks good

The schema for Azure Blob Storage configuration follows Kubernetes API conventions and properly defines required fields (container, root) and optional fields (endpoint, secretName).


18554-18567: Note: Intentional duplication of Azure Blob Storage configuration

This is an intentional duplication of the Azure Blob Storage configuration schema, allowing separate storage configuration for monitoring and main data components. The schema is consistent with the previous definition.

@daviderli614 daviderli614 requested a review from zyy17 November 26, 2024 09:44
@daviderli614 daviderli614 changed the title chore: bump greptimedb-operator version to v0.1.3 chore(greptimedb-operator): bump greptimedb-operator version to v0.1.3 Nov 26, 2024
@zyy17 zyy17 merged commit 5b0385d into GreptimeTeam:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants