fix: release failed #210
fix: release failed #210
Conversation
WalkthroughThe changes in this pull request primarily focus on updating the release workflow for Helm charts. A new job for releasing charts to ACR has been introduced, along with modifications to existing jobs to include a Jaeger Helm chart repository. The version number for the Changes
Possibly related PRs
Suggested reviewers
Warning Rate limit exceeded@zyy17 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 31 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
.github/workflows/release.yaml (2)
Line range hint
47-67: Consider adding error handling and version verificationWhile the implementation is functional, consider these improvements:
- Add error handling for the registry login step
- Verify chart versions before pushing to ensure consistency
- name: Login to OCI registry run: | + set -e echo '${{ secrets.ALICLOUD_PASSWORD }}' | helm registry login ${{ vars.OCI_REGISTRY_URL }} -u ${{ secrets.ALICLOUD_USERNAME }} --password-stdin + if [ $? -ne 0 ]; then + echo "Failed to login to registry" + exit 1 + fi
Line range hint
82-84: Replace fixed delay with GitHub Pages deployment status checkThe current implementation uses a fixed 5-minute sleep which is not reliable and extends the workflow duration unnecessarily.
Consider using the GitHub API to check the actual deployment status:
- name: Wait for deployment of GitHub Pages run: | - sleep 300 + MAX_ATTEMPTS=30 + ATTEMPT=0 + while [ $ATTEMPT -lt $MAX_ATTEMPTS ]; do + STATUS=$(gh api repos/${{ github.repository }}/pages/deployment -q '.status') + if [ "$STATUS" = "success" ]; then + echo "GitHub Pages deployment completed successfully" + exit 0 + fi + echo "Waiting for GitHub Pages deployment (attempt $ATTEMPT)..." + sleep 30 + ATTEMPT=$((ATTEMPT + 1)) + done + echo "Timeout waiting for GitHub Pages deployment" + exit 1 env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
.github/workflows/release.yaml(1 hunks)charts/greptimedb-cluster/Chart.yaml(1 hunks)charts/greptimedb-cluster/README.md(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- charts/greptimedb-cluster/Chart.yaml
- charts/greptimedb-cluster/README.md
🔇 Additional comments (1)
.github/workflows/release.yaml (1)
Line range hint 3-12: Verify workflow trigger conditions
The workflow can be triggered by:
- Push to main branch
- Manual trigger with optional ACR release parameter
Consider adding:
- Release tag triggers for automated releases
- Environment-specific conditions for different targets
✅ Verification successful
Workflow triggers are well-configured for the release process
The current trigger configuration is appropriate for the release workflow:
- The
release.yamlworkflow is the only one triggered on push to main, avoiding any conflicts - The manual trigger with ACR parameter provides flexibility for targeted releases
- Other workflows (
CI,E2E,PR Title Checker) have distinct, non-conflicting triggers - The release process is properly orchestrated across multiple targets:
- GitHub Pages (via chart-releaser)
- ACR (conditional on push or manual trigger)
- S3 (dependent on GitHub Pages release)
Adding tag triggers is unnecessary as the current setup follows the trunk-based development model where releases are managed through main branch pushes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any other workflow files that might conflict with these triggers
rg -l 'on:\s*push:\s*branches:\s*-\s*main' .github/workflows/
Length of output: 63
Script:
#!/bin/bash
# List all workflow files and their content to analyze trigger conditions
fd . .github/workflows/ -e yml -e yaml --exec cat {}
Length of output: 5881
Summary by CodeRabbit
New Features
Updates
greptimedb-clusterHelm chart from0.2.37to0.2.38.greptimedb-clusterHelm chart.