Make CNC outline operation respect the ease down option #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thank you for a great opensource tool!
I noticed that the CNC outline operation didn't respect the ease down option and I needed that in my work flow so I changed the OPOutline class so that now it does.
I don't know if there was reason for the outlines not to use it but decided to open a pr in case that was a bug and you would be interested in adding this to the master.
I tested with couple of my parts that outlines seems to be working with and without the ease down option but didn't do any wider testing.
With a quick look I didn't see any contributing guide so let me know if you are accepting contributions and if there is a process I should follow.