Skip to content

Commit

Permalink
Merge branch 'issue_58' into gs_master
Browse files Browse the repository at this point in the history
fix Issue #60.
updated REST tests from @HeSe
WebSocket packages from @HeSe, but still issues with loading
Cryptography package (Issue #58)
  • Loading branch information
dalehenrich committed Nov 18, 2014
2 parents 42df505 + 17acd86 commit e3e6e4e
Show file tree
Hide file tree
Showing 39 changed files with 145 additions and 123 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
language: erlang

env:
# - ST=GemStone-2.4.4.1
- ST=GemStone-2.4.4.1
# - ST=GemStone-2.4.4.7
# - ST=GemStone-2.4.5
- ST=GemStone-2.4.6
# - ST=GemStone-3.0.1 # not suppored in GemStone 3.0.1
- ST=GemStone-3.1.0.6
- ST=GemStone-3.2.2
- ST=GemStone-3.2.3

# blacklist master as it is the "shared code" branch
branches:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@ baseline: spec
spec
versionString: #'stable';
repository: 'http://www.squeaksource.com/MetacelloRepository' ];
configuration: 'Neo JSON'
with: [
spec
versionString: #'stable';
repository: 'http://mc.stfx.eu/Neo' ].
yourself.
spec
package: 'Zinc-Character-Encoding-Core';
package: 'Zinc-Character-Encoding-Tests'
Expand All @@ -28,7 +24,7 @@ baseline: spec
package: 'Zinc-Patch-HTTPSocket' with: [ spec requires: 'Zinc-HTTP' ];
package: 'Zinc-AWS'
with: [ spec requires: #('Zinc-HTTP' 'XML Support') ];
package: 'Zinc-REST' with: [ spec requires: #('Zinc-HTTP' 'Neo JSON') ];
package: 'Zinc-REST' with: [ spec requires: #('Zinc-HTTP' 'NeoJSON') ];
package: 'Zinc-Zodiac'
with: [ spec requires: #('Zinc-HTTP' 'Zodiac-Core' 'Zodiac-Tests') ];
package: 'Zodiac-Core';
Expand All @@ -37,9 +33,9 @@ baseline: spec
package: 'Zinc-WebSocket-Tests'
with: [ spec requires: 'Zinc-WebSocket-Core' ];
package: 'Zinc-SSO-OAuth1-Core'
with: [ spec requires: #('Zinc-HTTP' 'Neo JSON') ];
with: [ spec requires: #('Zinc-HTTP' 'NeoJSON') ];
package: 'Zinc-SSO-OAuth2-Core'
with: [ spec requires: #('Zinc-HTTP' 'Neo JSON') ];
with: [ spec requires: #('Zinc-HTTP' 'NeoJSON') ];
package: 'Zinc-SSO-OpenID-Core'
with: [ spec requires: #('Zinc-HTTP' 'XML Support') ];
package: 'Zinc-SSO-Demo'
Expand All @@ -58,6 +54,7 @@ baseline: spec
spec
group: 'default' with: #('Core');
group: 'Core' with: #('Zinc-HTTP');
group: 'CI' with: #('default' 'Tests');
group: 'Tests'
with:
#('Zinc-Tests' 'Zinc-Character-Encoding-Tests' 'Zinc-Resource-Meta-Tests');
Expand Down Expand Up @@ -89,6 +86,13 @@ baseline: spec
spec
for: #'squeakCommon'
do: [
spec
configuration: 'NeoJSON'
with: [
spec
versionString: #'stable';
repository: 'http://mc.stfx.eu/Neo' ];
yourself.
spec package: 'Zinc-Patch-HTTPSocket' with: [ spec requires: 'Zinc-HTTP' ].
spec group: 'Patch-HTTPSocket' with: #('Zinc-Patch-HTTPSocket') ].
spec
Expand Down Expand Up @@ -118,16 +122,32 @@ baseline: spec
with: [
spec
version: '0.9.2';
repository: 'http://seaside.gemtalksystems.com/ss/PharoCompat' ].
repository: 'http://seaside.gemtalksystems.com/ss/PharoCompat' ];
configuration: 'Cryptography'
with: [
spec
versionString: #'stable';
repository: 'http://seaside.gemtalksystems.com/ss/Cryptography' ];
baseline: 'NeoJSON'
with: [
spec
loads: 'Core';
repository: 'github://GsDevKit/NeoJSON:master/repository' ];
yourself.
spec
package: 'SocketStream';
package: 'Zinc-FileSystem-Legacy' with: [ spec requires: #('GLASS1') ];
package: 'Zinc-WebSocket-Core'
with: [ spec requires: #('Zinc-HTTP' 'Cryptography') ];
package: 'Zinc-HTTP'
with: [
spec
requires: #('GLASS1' 'Zinc-FileSystem-Legacy');
includes: #('SocketStream') ];
package: 'Zinc-Tests' with: [ spec requires: #('GsPharo') ] ].
package: 'Zinc-Tests' with: [ spec requires: #('GsPharo') ].
spec
group: 'CI' with: #('REST');
yourself ].
spec
for: #'gs2.x'
do: [
Expand All @@ -145,6 +165,8 @@ baseline: spec
with: [ spec includes: 'Zinc-Character-Encoding-GS3-Tests' ];
package: 'Zinc-Character-Encoding-GS3-Tests'
with: [ spec requires: 'Zinc-Character-Encoding-Tests' ];
package: 'Zinc-WebSocket-Core'
with: [ spec requires: #('Zinc-HTTP' 'Cryptography') ];
yourself ].
spec
for: #(#'gs2.x' #'gs3.0.x')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"class" : {
},
"instance" : {
"baseline:" : "dkh 10/15/2014 11:47" } }
"baseline:" : "dkh 11/17/2014 18:15" } }
Original file line number Diff line number Diff line change
@@ -1 +1 @@
(name 'BaselineOfZincHTTPComponents-dkh.3' message 'Issue #55: bump mcz version of the gs_master branch BaselineOfZincHTTPComponents, to avoid duplice mcz versions' id 'e175a78c-9a07-4da1-97a2-96eb0d40ba96' date '10/27/2014' time '15:10:49' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.2' message 'restore Zodiac packages and groups to configuration ... not ported to GemStone yet, see Issue #55 for details' id '6311a4fb-03de-42dc-81c7-b96971d30368' date '10/15/2014' time '11:55:57' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-JohanBrichau.1' message 'renamed BaselineOfZinc to BaselineOfZincHTTPComponents' id 'e022a66b-5bb4-47eb-b582-74a3ebaa1f9e' date '07/09/2014' time '21:16:19' author 'JohanBrichau' ancestors () stepChildren ())) stepChildren ())) stepChildren ())
(name 'BaselineOfZincHTTPComponents-dkh.10' message 'Issue #58: pull WebSockt from CI group ... interested in seeing how things are for NeoJSON and and zinc core' id '3b28664e-1ba7-4d76-aff5-e5c89eb2236b' date '11/17/2014' time '18:16:16' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.9' message 'Issue #60: reference GsDevKit/NeoJSON directory and only load Core, since NeoJSON tests are known not to pass: https://github.com/GsDevKit/NeoJSON/issues/3' id '73c88fdd-cbe7-4a5c-8485-923f314c6c44' date '11/17/2014' time '18:14:59' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.8' message 'Issue #58: re-enable websocket as part of CI ... this will take longer to get straightened out as both NeoJSON and WebSockets have issues' id '342aa976-a532-4d8b-a428-6e7cb9111a41' date '11/17/2014' time '18:03:43' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.7' message 'Issue #58: disable web-socket test load for ''CI'' until Cryptography load issue resolvedIssue #60: fix NeoJSON specification and add ''REST'' to ''CI'' group ... defer reference to GsDevKit/NeoJSON project until travis tests have been enabled ...' id 'fec29f56-7062-41a6-85d2-9d7a439559e4' date '11/17/2014' time '16:33:26' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.6' message 'Issue #58: cryptography configuration needed updating, so added stable version while I was at it ...' id '00296be5-2d30-418d-a474-2f373393e313' date '11/01/2014' time '13:00:26' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.5' message 'Issue #58: no stable version defined in the current Cryptography configuration...' id '67a67e96-6cf9-4c32-a87a-9e3d8bc3d647' date '11/01/2014' time '12:46:46' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.4' message 'Issue #58: create CI group to specifiy packages to be loaded by travis-ci for testing ... for GemStone that includes Zinc-WebSocket-Tests ... expect failures since Cryptography project is not up to snuff...yet' id '15af9af6-9829-412c-be6b-70cdc7fda24a' date '11/01/2014' time '12:28:52' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.3' message 'Issue #55: bump mcz version of the gs_master branch BaselineOfZincHTTPComponents, to avoid duplice mcz versions' id 'e175a78c-9a07-4da1-97a2-96eb0d40ba96' date '10/27/2014' time '15:10:49' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-dkh.2' message 'restore Zodiac packages and groups to configuration ... not ported to GemStone yet, see Issue #55 for details' id '6311a4fb-03de-42dc-81c7-b96971d30368' date '10/15/2014' time '11:55:57' author 'dkh' ancestors ((name 'BaselineOfZincHTTPComponents-JohanBrichau.1' message 'renamed BaselineOfZinc to BaselineOfZincHTTPComponents' id 'e022a66b-5bb4-47eb-b582-74a3ebaa1f9e' date '07/09/2014' time '21:16:19' author 'JohanBrichau' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
"httpGetDocument:args:" : "SvenVanCaekenberghe 9/14/2010 08:18",
"httpGetDocument:args:accept:" : "SvenVanCaekenberghe 9/20/2011 13:39",
"httpGetDocument:args:accept:request:" : "SvenVanCaekenberghe 8/19/2011 11:19",
"httpGif:" : "SvenVanCaekenberghe 9/15/2011 16:28",
"httpPng:" : "SvenVanCaekenberghe 9/15/2011 16:28",
"httpPost:args:accept:" : "SvenVanCaekenberghe 8/19/2011 11:28",
"httpPost:args:user:passwd:" : "SvenVanCaekenberghe 8/19/2011 11:34",
"httpPostDocument:args:" : "SvenVanCaekenberghe 9/17/2010 20:05",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
system startup
startUp: resuming
"Our system startUp hook: start all servers we manage.
We do this using deferred startup actions to allow normal error handling."
"noop for gemstone ... always explicitly start server on startup for GemStone"

(resuming or: [ self alwaysRestart ])
ifTrue: [
Smalltalk addDeferredStartupAction: [
self managedServers do: [ :each | each start ] ] ]
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"shutDown:" : "SvenVanCaekenberghe 9/18/2012 13:38",
"startDefaultOn:" : "SvenVanCaekenberghe 12/22/2011 12:04",
"startOn:" : "SvenVanCaekenberghe 12/22/2011 11:30",
"startUp:" : "SvenVanCaekenberghe 9/29/2012 20:51",
"startUp:" : "dkh 11/17/2014 16:04",
"stopDefault" : "SvenVanCaekenberghe 12/22/2011 11:29",
"unregister:" : "SvenVanCaekenberghe 8/18/2011 14:10" },
"instance" : {
Expand Down
2 changes: 1 addition & 1 deletion repository/Zinc-HTTP.package/monticello.meta/version

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
testing
expectedFailures
^ #(#'testQuery')
Original file line number Diff line number Diff line change
@@ -1,28 +1,27 @@
testing
testCreate
"You create a new entry by posting a JSON map representation to /storage/objects
"You create a new entry by posting a JSON map representation to /storage/objects
The result is a 201 Created response with the URI of the new object both
returned as a JSON string and as the Location header"

| data objectUri |
data := Dictionary with: #x -> 'foo' with: #y -> 'bar'.
client
addPathSegment: 'objects';
contents: data;
post.
self assert: client isSuccess.
self assert: client isCreated.
objectUri := client response location.
self assert: objectUri isString & objectUri isEmpty not.
self assert: client contents equals: objectUri.
client resetEntity.
client get.
self assert: client isSuccess.
self assert: (client contents includes: objectUri).
client
url: objectUri;
get.
self assert: client isSuccess.
data keysAndValuesDo: [ :key :value |
(client contents at: key) = value ].
self assert: (client contents at: #'object-uri') equals: objectUri

| data objectUri |
data := Dictionary with: 'x' -> 'foo' with: 'y' -> 'bar'.
client
addPathSegment: 'objects';
contents: data;
post.
self assert: client isSuccess.
self assert: client isCreated.
objectUri := client response location.
self assert: objectUri isString & objectUri isEmpty not.
self assert: client contents equals: objectUri.
client resetEntity.
client get.
self assert: client isSuccess.
self assert: (client contents includes: objectUri).
client
url: objectUri;
get.
self assert: client isSuccess.
data keysAndValuesDo: [ :key :value | (client contents at: key) = value ].
self assert: (client contents at: 'object-uri') equals: objectUri
Original file line number Diff line number Diff line change
@@ -1,26 +1,25 @@
testing
testUpdate
"To update an existing object you PUT a new JSON map representation to an existing uri"

| data objectUri |
data := Dictionary with: #x -> 'foo' with: #y -> 'bar'.
client
addPathSegment: 'objects';
contents: data;
post.
self assert: client isCreated.
objectUri := client response location.
client resetEntity.
data at: #z put: 100.
client
url: objectUri;
contents: data;
put.
self assert: client isSuccess.
client resetEntity.
client get.
self assert: client isSuccess.
data keysAndValuesDo: [ :key :value |
(client contents at: key) = value ].
self assert: (client contents at: #'object-uri') equals: objectUri.
self assert: (client contents at: #z) equals: 100
"To update an existing object you PUT a new JSON map representation to an existing uri"

| data objectUri |
data := Dictionary with: 'x' -> 'foo' with: 'y' -> 'bar'.
client
addPathSegment: 'objects';
contents: data;
post.
self assert: client isCreated.
objectUri := client response location.
client resetEntity.
data at: 'z' put: 100.
client
url: objectUri;
contents: data;
put.
self assert: client isSuccess.
client resetEntity.
client get.
self assert: client isSuccess.
data keysAndValuesDo: [ :key :value | (client contents at: key) = value ].
self assert: (client contents at: 'object-uri') equals: objectUri.
self assert: (client contents at: 'z') equals: 100
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
"class" : {
},
"instance" : {
"expectedFailures" : "dkh 11/17/2014 16:48",
"setUp" : "SvenVanCaekenberghe 12/10/2012 20:03",
"tearDown" : "SvenVanCaekenberghe 12/10/2012 19:18",
"testCreate" : "SvenVanCaekenberghe 12/12/2012 10:26",
"testCreate" : "dkh 11/17/2014 16:45",
"testDelete" : "SvenVanCaekenberghe 12/12/2012 10:26",
"testEmpty" : "SvenVanCaekenberghe 12/10/2012 21:25",
"testQuery" : "SvenVanCaekenberghe 12/12/2012 10:27",
"testUpdate" : "SvenVanCaekenberghe 12/12/2012 10:28" } }
"testUpdate" : "dkh 11/17/2014 16:46" } }
1 change: 0 additions & 1 deletion repository/Zinc-REST.package/monticello.meta/categories.st
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
SystemOrganization addCategory: #'Zinc-REST'!
SystemOrganization addCategory: #'Zinc-REST-Server'!
SystemOrganization addCategory: #'Zinc-REST-Tests'!
Loading

0 comments on commit e3e6e4e

Please sign in to comment.