Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Johan's issues #43

Closed
dalehenrich opened this issue Jun 23, 2013 · 5 comments
Closed

Address Johan's issues #43

dalehenrich opened this issue Jun 23, 2013 · 5 comments
Labels
inprocess task
Milestone
2.4.3.1

Comments

@dalehenrich
Copy link
Member

dalehenrich pushed a commit that referenced this issue Jul 19, 2013
switch to using github://glassdb/glass:master/repository repository f…
e180ac2 
…or GLASS

fix Issue #43: CharacterCollection>>includesSubstring: added to GLASS1 package
@HeSe
Copy link

HeSe commented Dec 11, 2014

asString36 is also needed by Mapless. My virgin gsDevKit install does not include "asString36" it would be great if those methods would be part of the core Squeak pacakges

@dalehenrich
Copy link
Member Author

@HeSe asString36 goes into the GsSqueakCommon-Core package as well, could you add it along with printStringHex and issue a pull request when you have got Mapless running green?

@HeSe
Copy link

HeSe commented Dec 11, 2014

I'll do that asap

dalehenrich added a commit to glassdb/glass that referenced this issue Dec 11, 2014
@dalehenrich
partial fix for GsDevKit/zinc#43
81c64a5
dalehenrich added a commit that referenced this issue Dec 11, 2014
@dalehenrich
moved UUID>>asString36 to GLASS1 (see #43)
ed1375d
dalehenrich added a commit to glassdb/glass that referenced this issue Dec 11, 2014
@dalehenrich
partial fix for GsDevKit/zinc#43
09d543a 
 (for 2.4.x)
@dalehenrich
Copy link
Member Author

looks like CharacterCollection>>includesSubstring: has been there since glassdb/glass@67ee3bf (committed in July of 2013)

dalehenrich added a commit that referenced this issue Dec 11, 2014
@dalehenrich
Issue #43: move SocketStream class>>openConnectionToHost:port:timeout…
15dc80d 
…: to SocketStream package
@dalehenrich
Copy link
Member Author

with this last commit, I think we've addressed all three issues ... will be part of issue_58 branch merge (Issue #58)

@dalehenrich dalehenrich mentioned this issue Dec 15, 2014
Merged
10 tasks
@dalehenrich dalehenrich modified the milestone: 2.4.3.1 Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inprocess task
Projects
None yet
Milestone
2.4.3.1
Development

No branches or pull requests
2 participants
@dalehenrich @HeSe