Feature/support on demand access

[yair-develeap]

Support OnDemandAccess --> see api: https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref_users_and_groups.htm#create_group

Disable MinimumSiteRole requirement .. as it is optional .

tested locally using filesystem_mirror . and it works as it should .

[yair-develeap]

Hi @GtheSheep any updates on this PR ?

[GtheSheep]

Hi @GtheSheep any updates on this PR ?

Will take a look this afternoon! thanks

[GtheSheep]

@yair-develeap seems reasonable! Thanks for putting this up! 🙌
Could you please:

• Run make fmt to format
• Run make doc to add the new flag to the site docs
• Add a basic test case for this flag/ it's intended use into group_resource_test.go
  Thanks!

[yair-develeap]

Hi @GtheSheep . done , including test cases .
ive also added a note for on_demand_access attribute . compatible from version 3.21 .

[GtheSheep]

Thanks!! Ran the tests locally, the on demand status doesn't seem to be getting set in the state correctly as it still appears in the plan after an apply.
If you don't have access to an instance to test this I can assist with the repo CI tomorrow, but it's likely a minor thing in how this can be true/ false/ nil or something 🤷🏻‍♂️

[yair-develeap]

Your assistance would be greatly appreciated. Thank you!

[GtheSheep]

Hey @yair-develeap - apologies for the delay, hectic time of year! But it seems like there's something weird going on with this API on Tableau's side, the docs suggest the param is ephemeralUsersEnabled instead of externalUserEnabled, but trying that parameter causes the request to fail! Whilst externalUserEnabled seems to have no impact, and neither are returned in the response when GET'ing a group.
Have you had any luck applying this via the API in any format? If so could you possibly paste an example here please, I'm not super familiar with this setting so may just be my setup.
Thanks!