Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Records that are Featured Worlds are not being fetched #192

Closed
stiefeljackal opened this issue Sep 2, 2023 · 2 comments · Fixed by #194 or #195
Closed

Records that are Featured Worlds are not being fetched #192

stiefeljackal opened this issue Sep 2, 2023 · 2 comments · Fixed by #194 or #195

Comments

@stiefeljackal
Copy link
Contributor

In the current implementation, records that are featured worlds are not being fetched by the tool. That was noticed by the Creator Jam (CJ) group that I belong in.
GuVAnj8Gv3RJ pushed a commit that referenced this issue Sep 3, 2023
fix(featured): encode onlyFeatured only if the user specifies it
aa79209 
Neos' Cloud will only do filtering on the "featured" state of a world IF the search parameters include it.

Json serialization was including it because CloudX does not implement SearchParameters.OnlyFeatured as a nullable type. Our custom extension of this, resolves this problem.

fixes #192
@GuVAnj8Gv3RJ GuVAnj8Gv3RJ mentioned this issue Sep 3, 2023
Merged
GuVAnj8Gv3RJ added a commit that referenced this issue Sep 3, 2023
@GuVAnj8Gv3RJ
fix(featured): encode onlyFeatured only if the user specifies it (#194)
345c569 
Neos' Cloud will only do filtering on the "featured" state of a world IF the search parameters include it.

Json serialization was including it because CloudX does not implement SearchParameters.OnlyFeatured as a nullable type. Our custom extension of this, resolves this problem.

fixes #192

Co-authored-by: GuVAnj8Gv3RJ <[email protected]>
@GuVAnj8Gv3RJ
Copy link
Owner

Null strikes again https://www.infoq.com/presentations/Null-References-The-Billion-Dollar-Mistake-Tony-Hoare/

@GuVAnj8Gv3RJ GuVAnj8Gv3RJ reopened this Sep 3, 2023
@GuVAnj8Gv3RJ
Copy link
Owner

I spoke to soon, standby

GuVAnj8Gv3RJ pushed a commit that referenced this issue Sep 3, 2023
fix(featured): ensure onlyFeatured is serialized correctly in all eve…
2b6f86e 
…ntualities

fixes #192 .. again
GuVAnj8Gv3RJ pushed a commit that referenced this issue Sep 3, 2023
fix(featured): ensure onlyFeatured is serialized correctly in all eve…
f918ae9 
…ntualities

fixes #192 .. again
@GuVAnj8Gv3RJ GuVAnj8Gv3RJ mentioned this issue Sep 3, 2023
Merged
GuVAnj8Gv3RJ added a commit that referenced this issue Sep 3, 2023
@GuVAnj8Gv3RJ
fix(featured): ensure onlyFeatured is serialized correctly in all eve…
ad92485 
…ntualities (#195)

fixes #192 .. again

Co-authored-by: GuVAnj8Gv3RJ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stiefeljackal @GuVAnj8Gv3RJ