Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency on rope; CVE-2014-3539 fix pending 4 years now #1366

Closed
ulidtko opened this issue Jul 26, 2018 · 0 comments
Closed

Drop dependency on rope; CVE-2014-3539 fix pending 4 years now #1366

ulidtko opened this issue Jul 26, 2018 · 0 comments
Assignees
@gsemet

Comments

@ulidtko
Copy link
Member

ulidtko commented Jul 26, 2018

Hey, @gsemet

I see you're doing great job maintaining Guake. Can you please look if it's possible to get rid of the dependency on the rope module? Because of this: python-rope/rope#105 -- years have passed, no RCE fix merged still.

Even though it's only a dev-dependency -- I guess nobody wants to get hacked while working on a small feature/fix to Guake just because we couldn't get out crap together.

cc @pypingou @clarete
gsemet added a commit that referenced this issue Jul 31, 2018
@gsemet
remove rope dependency
4db639f 
Fix #1366

+ freeze pip and pipenv

Signed-off-by: Gaetan Semet <[email protected]>
@gsemet gsemet mentioned this issue Jul 31, 2018
Closed
@gsemet gsemet closed this as completed in fee49fc Aug 1, 2018
gsemet added a commit that referenced this issue Sep 3, 2018
@gsemet
remove rope dependency
bab7ef3 
Fix #1366

+ freeze pip and pipenv

Signed-off-by: Gaetan Semet <[email protected]>
gsemet added a commit that referenced this issue Sep 3, 2018
@gsemet
remove rope dependency
5079bc9 
Fix #1366

+ freeze pip and pipenv

Signed-off-by: Gaetan Semet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsemet gsemet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsemet @ulidtko