Skip to content

Commit

Permalink
Rollup merge of rust-lang#48382 - GuillaumeGomez:fix-rustdoc-test-pan…
Browse files Browse the repository at this point in the history
…ic, r=estebank

Fix rustdoc test ICE

Fixes rust-lang#48377.

r? @QuietMisdreavus
  • Loading branch information
GuillaumeGomez authored Feb 21, 2018
2 parents d9f5eeb + 5cbf9ae commit c118d37
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 12 deletions.
27 changes: 15 additions & 12 deletions src/librustdoc/html/markdown.rs
Original file line number Diff line number Diff line change
Expand Up @@ -471,18 +471,21 @@ pub fn find_testable_code(doc: &str, tests: &mut ::test::Collector, position: Sp
break 'main;
}
}
let offset = offset.unwrap_or(0);
let lines = test_s.lines().map(|l| map_line(l).for_code());
let text = lines.collect::<Vec<&str>>().join("\n");
nb_lines += doc[prev_offset..offset].lines().count();
let line = tests.get_line() + (nb_lines - 1);
let filename = tests.get_filename();
tests.add_test(text.to_owned(),
block_info.should_panic, block_info.no_run,
block_info.ignore, block_info.test_harness,
block_info.compile_fail, block_info.error_codes,
line, filename, block_info.allow_fail);
prev_offset = offset;
if let Some(offset) = offset {
let lines = test_s.lines().map(|l| map_line(l).for_code());
let text = lines.collect::<Vec<&str>>().join("\n");
nb_lines += doc[prev_offset..offset].lines().count();
let line = tests.get_line() + (nb_lines - 1);
let filename = tests.get_filename();
tests.add_test(text.to_owned(),
block_info.should_panic, block_info.no_run,
block_info.ignore, block_info.test_harness,
block_info.compile_fail, block_info.error_codes,
line, filename, block_info.allow_fail);
prev_offset = offset;
} else {
break;
}
}
Event::Start(Tag::Header(level)) => {
register_header = Some(level as u32);
Expand Down
23 changes: 23 additions & 0 deletions src/test/rustdoc/issue-48377.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// compile-flags:--test

//! This is a doc comment
//!
//! ```rust
//! fn main() {}
//! ```
//!
//! With a trailing code fence
//! ```
/// Some foo function
pub fn foo() {}

0 comments on commit c118d37

Please sign in to comment.