Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

配置文件合并 #892

Merged
merged 7 commits into from
Feb 21, 2025
Merged

配置文件合并 #892

merged 7 commits into from
Feb 21, 2025

Conversation

wongsyrone
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Release
  • Other, please describe:

Which environment is this PR for? (check at least one)

  • Workflow
  • GUI
  • Docker
  • Command line
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue
    first and wait for approval before working on it)

Other information:

目前配置文件需要完全复制默认文件,更改配置项需要删除重建,如果配置未及时更新,会导致难以排查的bug。
修改后user_config.ini 文件只需要存储修改的配置项,注意ini section需要保持一致,user_config.ini覆盖config.ini中同section,同id的配置。
现有程序更新后,user_config.ini可只保留用户定制项,其余项删除。已经存在的配置由于是复制的默认文件,不修改也不会影响功能。

After this commit, user_config.ini contains modified entries only
@Guovin
Copy link
Owner

Guovin commented Feb 8, 2025

好的优化,验证通过。建议上述操作与注意项补充更新至教程文档说明 (docs/tutorial.md, docs/tutorial_en.md),用户创建user_config.ini可以只输入想要修改的配置项即可,无需全部复制config.ini。

@wongsyrone
Copy link
Contributor Author

这两天在出差,我要是有空就更一下文档

@wongsyrone
Copy link
Contributor Author

文档已更新

@Guovin
Copy link
Owner

Guovin commented Feb 9, 2025

麻烦辛苦在创建user_config.ini步骤中也补充一下这个提示

@wongsyrone
Copy link
Contributor Author

创建user_config.ini步骤中也补充一下这个提示

提示已补充

@Guovin
Copy link
Owner

Guovin commented Feb 9, 2025

我提了两个阅读体验上的建议,辛苦你修改一下

@Guovin
Copy link
Owner

Guovin commented Feb 21, 2025

你好,上述Codereview是否有空处理一下?

@wongsyrone
Copy link
Contributor Author

我看了一下,目前的文档我认为已经写的很明白了,如果你有其他优化的想法可以直接推送到这个分支,或者本地checkout之后优化一下。如果是为了小白使用,还是维持复制粘贴的形式,毕竟什么是ini配置节都可能不懂。

@Guovin
Copy link
Owner

Guovin commented Feb 21, 2025

已修改

@Guovin Guovin merged commit 4439563 into Guovin:master Feb 21, 2025
@wongsyrone wongsyrone deleted the merge-ini branch February 21, 2025 08:15
@Guovin Guovin mentioned this pull request Feb 21, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants