Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address some lint violations #219

Merged
merged 1 commit into from
Feb 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Metrics/ParameterLists:
Max: 5
CountKeywordArgs: false
Metrics/LineLength:
Max: 100
Max: 120
Exclude:
- lib/apollo-federation/tracing/proto/apollo_pb.rb

Expand Down
2 changes: 1 addition & 1 deletion lib/apollo-federation/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def self.included(klass)
end

module CommonMethods
DEFAULT_LINK_NAMESPACE = 'federation'.freeze
DEFAULT_LINK_NAMESPACE = 'federation'

def federation(version: '1.0', link: {})
@federation_version = version
Expand Down
6 changes: 3 additions & 3 deletions spec/apollo-federation/schema_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
expect(schema.federation_version).to eq('1.0')
end

it 'returns the specified version when set' do
it 'returns the specified version when set to 2.0' do
schema = Class.new(GraphQL::Schema) do
include ApolloFederation::Schema
federation version: '2.0'
Expand All @@ -23,7 +23,7 @@
expect(schema.federation_version).to eq('2.0')
end

it 'returns the specified version when set' do
it 'returns the specified version when set to 2.3' do
schema = Class.new(GraphQL::Schema) do
include ApolloFederation::Schema
federation version: '2.3'
Expand Down Expand Up @@ -88,7 +88,7 @@
expect(schema.federation_2?).to be(true)
end

it 'returns true when the version is a string greater than 2.0' do
it 'returns true when the version is a string equal to 2.3' do
schema = Class.new(GraphQL::Schema) do
include ApolloFederation::Schema
federation version: '2.3'
Expand Down