Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add continue button to company document list #163

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

serikjensen
Copy link
Member

This adds a continue action to the company document list.

Proof of functionality

Event firing for document signing done when continue button is selected

Screen.Recording.2025-02-24.at.5.00.53.PM.mov

Continue button enabled if not the signatory regardless of document signing status

Screenshot 2025-02-24 at 5 03 57 PM

Continue button disabled if self signatory and has documents to sign

Screenshot 2025-02-24 at 5 04 30 PM

Continue button enabled if self signatory and all documents are signed

Screenshot 2025-02-24 at 5 05 06 PM

Copy link
Contributor

@jeffredodd jeffredodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, once we have a solid build down to 🚢

@@ -82,7 +87,8 @@ function Root({ companyId, signatoryId, className, children }: DocumentListProps
documentListError,
handleRequestFormToSign,
handleChangeSignatory,
isSelfSignatory,
handleContinue,
isSelfSignatory: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why we're hard coding this?

Copy link
Member Author

@serikjensen serikjensen Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was testing for proof of functionality 🤦 will update lol good catch!

Copy link
Contributor

@jeffredodd jeffredodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serikjensen serikjensen merged commit b4ccaea into main Feb 25, 2025
1 check passed
@serikjensen serikjensen deleted the feat/GWS-3827 branch February 25, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants