Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog and add a comment for Settings id field #297

Merged
merged 5 commits into from
Jul 4, 2023

Conversation

Digitalone1
Copy link
Contributor

Just a comment for the purpose of the id string. Related to #292

Another minor thing. I'll point it out here since it's not so important. I noticed that you set 1190x670 as start size, but in another part of the code you maximize on startup. Don't know if it's intended to work that way but, if you need to maximize on start, maybe don't need to specify a start size...

@GyulyVGC
Copy link
Owner

GyulyVGC commented Jul 4, 2023

It's actually made on purpose.
If not specified, iced will use its default size (which I don't remember) and the screen will be maximised anyway an instant later.
Specifying a custom initial size has the benefit of setting it back when double clicking on the top most bar of the app.
I'm not aware of a configuration to immediately set it to the full screen size.
Note that it's not even suggested to set it to the screen resolution, since iced uses logical pixels which are not always equivalent to physical ones.

@Digitalone1 Digitalone1 changed the title Comment for Settings id field Update Changelog and add a comment for Settings id field Jul 4, 2023
@Digitalone1
Copy link
Contributor Author

Ok. I updated the changelog.

@GyulyVGC GyulyVGC added the documentation Improvements or additions to documentation label Jul 4, 2023
@GyulyVGC GyulyVGC added this to the v1.2.2 milestone Jul 4, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@GyulyVGC GyulyVGC merged commit d1202e4 into GyulyVGC:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants