Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add given_name and family_name claims to UserInfo #508

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

ThoFrank
Copy link
Contributor

The name splitting is using what was already implemented in nc for the
system address book

implements #506

The name splitting is using what was already implemented in nc for the
system address book
@ThoFrank
Copy link
Contributor Author

I looked a bit into the nextcloud code itself and found that the name splitting could be reused.
I tested it for my use case and it seems to work good enough. Of course this could be done a lot better. It even says so in the nc code:

public function splitFullName(string $fullName): array {
	// Very basic western style parsing. I'm not gonna implement
	// https://github.com/android/platform_packages_providers_contactsprovider/blob/master/src/com/android/providers/contacts/NameSplitter.java ;)

@H2CK H2CK merged commit aa1b04f into H2CK:master Dec 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants